Fix build failure issue on Carthage#275
Merged
lucdion merged 5 commits intolayoutBox:masterfrom Jun 7, 2025
Merged
Conversation
heoblitz
commented
Jun 5, 2025
| @@ -1,5 +1,5 @@ | |||
| source 'https://cdn.cocoapods.org/' | |||
| use_frameworks! | |||
| use_frameworks! :linkage => :static | |||
Collaborator
Author
There was a problem hiding this comment.
Adds configuration to include Yoga inside the xcframework, consistent with the existing wrapping structure.
This change does not affect environments using CocoaPods or Swift Package Manager.
| #import <yoga/Yoga.h> | ||
| #import <yoga/YGEnums.h> | ||
| #import <yoga/YGMacros.h> | ||
| #import <yoga/YGValue.h> |
Collaborator
Author
There was a problem hiding this comment.
Updates header import paths to use module paths instead of file paths.
Collaborator
Author
|
Hello! @lucdion Would it be possible to invite me to the organization with minimal access? |
Member
|
Hi @heoblitz, you gave you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR?
Since version 2.1.0, Yoga is managed as a separate dependency, so the project cannot be built on its own. Therefore, it cannot be used with Carthage.
Providing a pre-built static framework or adopting a different structure would require significant changes.
Instead, this PR updates the guide and some settings to maintain the current project structure while enabling Carthage support.
Test
spm ✅
cocoapods ✅
carthage ✅
FlexLayoutTest.zip
close #270