Prefer res_mods ribbon skins with bundled art fallback - #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
res_mods ribbon skins
ibbon_skin_dir(game_path): walks the game's
es_mods\ tree and returns the deepest \gui/ribbons\ directory (versioned mod folders), or null when unmodded
ibbonIcons.ts\ loader: resolves a ribbon by logical name — res_mods skin via convertFileSrc when installed, else the bundled stock art (res/images/ribbons, 33 main + 39 sub)
Next (pending ribbon-index mapping research)
The BattleResults [24+]\ counters bundle many battle stats; mapping each index to a specific ribbon needs the client's ribbon-list order. The loader + skin mechanism above is ready for the ribbon-strip UI once that mapping lands.