fix(cli): add BitNet to FAMILY_ORDER so family_order_is_exhaustive passes - #404
Merged
Conversation
…sses The BitNet family was missing from the mlxcel arch family-ordering table, so family_order_is_exhaustive failed and BitNet sorted under the unknown-family fallback instead of its intended position. Add "BitNet" after "RWKV" in the distinctive text-family cluster. Closes #402
inureyes
added
type:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BitNet family was missing from the
mlxcel archfamily-ordering table (FAMILY_ORDERinsrc/main.rs), so thefamily_order_is_exhaustiveguard test failed and BitNet sorted under the unknown-family fallback instead of its intended position. This was a pre-existing failure onmain, surfaced as a follow-up while implementing #164 (PR #400 did not touchsrc/main.rs).The fix adds
"BitNet"after"RWKV", placing it at the end of the distinctive text-family cluster (Falcon / LFM2 / PLaMo / RWKV) ahead of the speech and VLM sections, which matches BitNet b1.58 being a distinctive dense ternary family. The exact family string matchesModelType::BitNet's metadata insrc/models/mod.rs.Verified:
family_order_is_exhaustiveandfamily_order_has_no_orphansboth pass, andmlxcel archnow renders aBitNet:section withBitNet b1.58 (ternary).Closes #402