fix: repair merged host-port integration - #262
Merged
Merged
Conversation
Restore the &[SocketAddr] host_port implementation that was auto-merged into the test module when PR #260 and PR #258 landed together. Keep the first-address hostname tests from #243 and the host-port parsing tests from #257 in one valid test module so both behaviors remain covered. Validation: cargo fmt --check; CARGO_TARGET_DIR=/home/inureyes/Development/backend.ai/bssh/target cargo test --lib to_socket_addrs_with_hostname; CARGO_TARGET_DIR=/home/inureyes/Development/backend.ai/bssh/target cargo check --lib --tests; CARGO_TARGET_DIR=/home/inureyes/Development/backend.ai/bssh/target cargo clippy --lib --tests -- -D warnings.
inureyes
added
status:review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
&[SocketAddr]::host_portto the trait implementation after the PR chore: resolve host key verification follow-ups #260 / PR fix: preserve forwarded target hostnames by default #258 auto-merge placed it inside the test module.testsmodule so both behavior checks remain compiled.Validation
cargo fmt --checkCARGO_TARGET_DIR=/home/inureyes/Development/backend.ai/bssh/target cargo test --lib to_socket_addrs_with_hostnameCARGO_TARGET_DIR=/home/inureyes/Development/backend.ai/bssh/target cargo check --lib --testsCARGO_TARGET_DIR=/home/inureyes/Development/backend.ai/bssh/target cargo clippy --lib --tests -- -D warningsRefs #243.
Refs #257.