Support MPS (or CPU) as well as CUDA#1
Merged
Merged
Conversation
Choose device based upon whether CUDA or MPS is available, so that macOS can also be supported. See https://pytorch.org/docs/stable/notes/mps.html
As we now support mps and cpu, cudatoolkit becomes optional.
Owner
|
Hi @petebankhead , thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks great!
I wanted to test it, but I use a Mac and so don't have CUDA.
Not sure if it's the best way to do it, but in case CUDA isn't available this PR tries to switch to use the MPS backend if possible, or CPU as a last resort.
That change was enough for me to get https://github.com/ksugar/qupath-extension-sam working on my Mac.