Remove rollouts from kpt as rollouts implement similar functionality to Porch#4402
Remove rollouts from kpt as rollouts implement similar functionality to Porch#4402liamfallon wants to merge 5 commits intokptdev:mainfrom
Conversation
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon
requested review from
efiacor,
kispaljr and
mozesl-nokia
as code owners
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR removes the rollouts functionality from kpt, as it is an alpha/deprecated feature being replaced by Porch from the Nephio Project. The PR includes extensive file deletions of rollouts-related code, removal of rollouts dependencies, and some code modernization updates (using any instead of interface{}, using slices and maps packages).
Changes:
- Complete removal of the
rollouts/directory and all rollouts-related functionality - Removal of rollouts commands from the alpha CLI
- Code modernization: replacing
interface{}withany, usingslices.Contains()andmaps.Copy() - Addition of a new boilerplate file at
scripts/boilerplate.go.txt
Reviewed changes
Copilot reviewed 143 out of 146 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rollouts/* (deleted) | Entire rollouts directory removed including API, controllers, pkg, config, scripts |
| commands/alpha/rollouts/* (deleted) | Rollouts CLI commands removed |
| commands/alpha/alphacmd.go | Rollouts command registration removed |
| go.mod/go.sum | Rollouts and related dependencies removed |
| thirdparty/cmdconfig/commands/runner/runner.go | Refactored to use slices.Contains |
| pkg/test/porch/cluster.go | kubectl command modified (contains bug) |
| pkg/test/runner/runner.go | Updated to use strings.SplitSeq |
| pkg/status/poller.go | Removed RolloutStatusReader |
| pkg/status/rollout.go (deleted) | Rollout status functionality removed |
| scripts/boilerplate.go.txt (added) | New boilerplate file |
| Various files | Code modernization: interface{} → any, using slices/maps packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: liamfallon <liam.fallon@est.tech>
dosubot
bot
added
the
size:XXL
Signed-off-by: liamfallon <liam.fallon@est.tech>
dosubot
bot
added
size:XL
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 142 out of 145 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon
force-pushed
the
fix-rollout-build
branch
from
b2ed7ae to
43c7f2d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 142 out of 145 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Should we not move this to hack/boilerplate.go.txt? Also, shouldn't we have one for yamls as well?
4 participants
Rollouts are an "alpha" concept in kpt for deploying workloads to clusters. However, the recommended approach for deploying workloads in kpt is using Porch from the Nephio Project. This PR removes rollouts from kpt as they are not supported and will not be developed any further.
Removing rollouts resolves the backlog issues that have been raised on rollouts below:
Fixes: #4403
Fixes: #3688
Fixes: #3777
Fixes: #3767
Fixes: #3773
Fixes: #3885
Fixes: #3778
Fixes: #3886
Fixes: #3835
Fixes: #3858
Fixes: #3839
Fixes: #3855
Fixes: #3862
Fixes: #3836
Fixes: #3854
Fixes: #3866
Fixes: #3775
Fixes: #3297
Fixes: #3119
Fixes: #3343
Fixes: #3351