Skip to content

Add more optimizer dependency support#2376

Open
gesen2egee wants to merge 5 commits into
kohya-ss:mainfrom
gesen2egee:feat-add-more-optimizers
Open

Add more optimizer dependency support#2376
gesen2egee wants to merge 5 commits into
kohya-ss:mainfrom
gesen2egee:feat-add-more-optimizers

Conversation

@gesen2egee

@gesen2egee gesen2egee commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add optimizer dependency updates for additional optimizer support.
  • Pin pytorch-optimizer to commit 3d08fa0.
  • Update adv-optm to 2.5.2.
  • Preserve Prodigy / DAdapt learning-rate logging while supporting effective_lr logging from upstream.

@gesen2egee
gesen2egee marked this pull request as ready for review June 12, 2026 11:35
@kohya-ss

Copy link
Copy Markdown
Owner

Thanks for the PR. Could you clarify why schedulefree and pytorch-optimizer need to be installed from Git commits instead of PyPI releases? For default requirements, we generally prefer released version pins for reproducibility and install stability.

Also, torch-optimi and adv-optm appear to be newly added default dependencies, but this PR does not seem to add direct code paths that require them. Since arbitrary optimizer classes can already be used by installing optional packages separately, could you remove these from requirements.txt unless they are required for a default/supported path?

@gesen2egee

gesen2egee commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback. Here is a quick clarification:
schedulefree & pytorch-optimizer (Git commits): Because the latest PyPI releases lack new features—specifically, the Schedule-Free+ variants and several newly added optimizers.

torch-optimi & adv-optm: They provide Stochastic Rounding and Kahan Rounding implementations for common optimizers (which are fully supported and utilized by frameworks like onetrainer). They are essential for preventing gradient underflow in low-precision training

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants