refactor: pr dependent dropdowns, toast position on mobile.#31
Merged
knightedcodemonkey merged 2 commits intomainfrom Mar 24, 2026
Merged
refactor: pr dependent dropdowns, toast position on mobile.#31knightedcodemonkey merged 2 commits intomainfrom
knightedcodemonkey merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the “Open Pull Request” drawer UX to make the base branch selection repository-dependent (loaded from GitHub), and adjusts mobile UI layering/positioning to improve overlay behavior.
Changes:
- Replace the PR base branch text input with a disabled-by-default
<select>that is populated from GitHub branches per selected repo. - Add GitHub API support for listing repository branches (with pagination + dedupe) and wire it into the PR drawer with caching/abort handling.
- Tweak mobile UI: move toast to the bottom and adjust PR drawer form grid layout for small screens; add Playwright coverage for the new base-branch dropdown behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/dialogs-overlays.css | Adjusts toast z-index and positions it at the bottom on mobile. |
| src/styles/ai-controls.css | Updates PR drawer form grid layout for mobile (2-column with specific fields spanning full width). |
| src/modules/github-pr-drawer.js | Adds branch loading/caching/abort logic and renders base branch options for the new dropdown. |
| src/modules/github-api.js | Introduces listRepositoryBranches() and supporting normalization/pagination helpers. |
| src/index.html | Switches base branch control from <input> to <select> with an initial main option. |
| playwright/app.spec.ts | Mocks branches endpoint in BYOT helper and adds an E2E test for base dropdown updates by repo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.