Skip to content

Admin team wildcard search - #3

Merged
kimden merged 2 commits into
kimden:masterfrom
heuchiKimdenSTK:admin-team-substring
Jun 21, 2021
Merged

Admin team wildcard search#3
kimden merged 2 commits into
kimden:masterfrom
heuchiKimdenSTK:admin-team-substring

Conversation

@heuchi

@heuchi heuchi commented Jun 21, 2021

Copy link
Copy Markdown

Use wildcard search for /admin team
You can use * and ? in the player name which is converted into a regular expression search internally. Since player names cannot contain any other characters that would needed to be escaped, it isn't done.
If no wildcard is used (no * or ?) a player's team color can be set even if the player is absent (as before).
If a wildcard is used and there is a unique match, the team color of that player is changed. If there is no match or more than one, an error message is printed.

Wildcard search is not case sensitive. Please let me know, if you want it to be.

Branch is now somehow misnamed... ;)

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

@kimden
kimden merged commit 7d72ab9 into kimden:master Jun 21, 2021
@kimden

kimden commented Jun 26, 2021

Copy link
Copy Markdown
Owner

There was a minor bug that led to kart colors not changing (unlike displayed teams in lobby), but seems like I have already fixed it (837ea11). I hope my logic didn't fail now and I haven't missed anything else :)

@heuchi

heuchi commented Jun 27, 2021

Copy link
Copy Markdown
Author

Oops, yeah, I didn't see that wide_player_name was still used later.

@kimden kimden added the T: improvement New feature or request label Sep 8, 2021
kimden pushed a commit that referenced this pull request Sep 16, 2024
* Rewrite NewsManager

* Add open link function

* Small fixes

* Try fix build crash

* Try fix build crash #2

* Try fix build crash #3

* Fix multiple error message & Add empty indicator

Hope the build would pass since the actions in the pr isn't updated yet
kimden pushed a commit that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T: improvement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants