Admin team wildcard search - #3
Merged
Merged
Conversation
kimden
added a commit
that referenced
this pull request
Jun 26, 2021
Owner
|
There was a minor bug that led to kart colors not changing (unlike displayed teams in lobby), but seems like I have already fixed it (837ea11). I hope my logic didn't fail now and I haven't missed anything else :) |
Author
|
Oops, yeah, I didn't see that wide_player_name was still used later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use wildcard search for /admin team
You can use * and ? in the player name which is converted into a regular expression search internally. Since player names cannot contain any other characters that would needed to be escaped, it isn't done.
If no wildcard is used (no * or ?) a player's team color can be set even if the player is absent (as before).
If a wildcard is used and there is a unique match, the team color of that player is changed. If there is no match or more than one, an error message is printed.
Wildcard search is not case sensitive. Please let me know, if you want it to be.
Branch is now somehow misnamed... ;)
Agreement