Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors parts of the
simplex.goimplementation to simplify indexing logic and remove unused code, resulting in a cleaner and slightly more efficient codebase. The main changes include updating index types and access patterns in the noise generation function, removing the unuseddot2Dfunction, and deleting its associated benchmark.Refactoring and simplification of indexing logic:
Noise2to useuint8for indices and direct indexing forpermandgrad, replacing slice windows and type conversions for improved clarity and performance. (simplex.go, simplex.goL85-R92)tablefrom a slice to an array for better type safety. (simplex.go, simplex.goL13-R13)Code cleanup:
dot2Dfunction, eliminating dead code from the codebase. (simplex.go, simplex.goL118-R114)BenchmarkDotbenchmark and its related comments, as it is no longer relevant after removingdot2D. (simplex_test.go, simplex_test.goL42-L61)Minor math simplification:
pow4function by removing redundant lines and returning the result directly. (simplex.go, simplex.goL118-R114)