Merged
Conversation
…iance - Bug 1: net_version no longer double-converts decimal chainId as hex - Bug 2: convertToHex uses parseEther instead of lossy float math - Bug 3: handleTransfer uses parseEther for amount conversion - Bug 4: eth_gasPrice handles null gasPrice on EIP-1559 chains - Bug 6: wallet_addEthereumChain requires user approval before adding - Bug 7: signTypedData handles both string and object typed data - Bug 8: eth_sign uses correct param order [address, message] - Bug 10: failedRpcs map cleaned up on each getProvider call Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- personal_sign now prefers dApp-supplied params[1] address so multi-account wallets use the correct derivation path (EIP-191 params = [message, address]). Falls back to global ADDRESS when not provided. - Drop @ts-expect-error on addEthereumChain approval event by including the required unsignedTx field (null) and narrowing status literal. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
BitHighlander
added a commit
that referenced
this pull request
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code