feat(solana): add SolanaTokenInfo and nanopb options#96
Closed
BitHighlander wants to merge 2 commits intomasterfrom
Closed
feat(solana): add SolanaTokenInfo and nanopb options#96BitHighlander wants to merge 2 commits intomasterfrom
BitHighlander wants to merge 2 commits intomasterfrom
Conversation
- SolanaTokenInfo message for SPL token display (mint, symbol, decimals) - token_info repeated field on SolanaSignTx (max 4 entries) - nanopb size limits for all Solana fields Enables firmware clear-signing of SPL token transfers.
Merged
5 tasks
Collaborator
Author
|
Superseded by combined PR #100 for simpler review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SolanaTokenInfomessage for SPL token display (mint, symbol, decimals)token_inforepeated field onSolanaSignTx(max 4 entries)messages-solana.prototo package build scriptsEnables firmware clear-signing of SPL token transfers with symbol display.
Files
messages-solana.proto— new message + fieldmessages-solana.options— nanopb limits (new file)package.json— build script updatedFirmware dependency
Unblocks keepkey/keepkey-firmware Solana support (7.14.0)
Test plan
protoccompiles cleanlynpm run buildsucceeds and emits Solana types