feat: ZcashDisplayAddress protocol (IDs 1308-1309)#101
Merged
pastaghost merged 1 commit intomasterfrom Apr 3, 2026
Merged
Conversation
Add unified address display and verification for Zcash Orchard. The host provides a unified address + FVK components (ak, nk, rivk), and the device re-derives its own keys to verify the Orchard receiver belongs to this seed before displaying the address. Messages: - ZcashDisplayAddress (1308, wire_in) - ZcashAddress (1309, wire_out)
BitHighlander
added a commit
to keepkey/python-keepkey
that referenced
this pull request
Apr 3, 2026
…-sign policy 1. ZcashDisplayAddress (1308) + ZcashAddress (1309): unified address display and verification via FVK re-derivation on device. - pb2 descriptors, mapping wire IDs, client method, test file 2. Solana AdvancedMode gate: SolanaSignMessage requires AdvancedMode policy enabled (no domain separation -- trezor #4371). - test_solana_sign_message_blocked_without_advanced_mode added 3. ETH blind-sign blocked: AdvancedMode OFF + contract data = Failure. - test_ethereum_blind_sign_blocked (E16) restored for 7.15+ 4. Recovery cipher strict: assertIsInstance(Failure) directly, no skipTest fallback for missing BIP-39 validation. 5. Fix duplicate test_solana_show_address in getaddress test. Depends on: keepkey/device-protocol#101 (ZcashDisplayAddress proto)
4 tasks
pastaghost
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZcashDisplayAddress(1308) andZcashAddress(1309) message types for on-device unified address verificationContext
PR #100 landed the full 7.14.0 protocol batch (Solana, TRON, TON, Zcash Orchard PCZT, EVM metadata, BIP-85). This PR adds the one remaining Zcash feature: address display/verification, which was deferred from that batch.
Files Changed
messages-zcash.proto— 2 new messages (ZcashDisplayAddress, ZcashAddress)messages.proto— 2 new MessageType enum entries (1308, 1309)messages-zcash.options— nanopb size constraints for new fieldsTest Plan
protocandnanopbfeat/zcash-display-addressbranch uses these messages