SAM-147: black format all files#420
Conversation
… for using pipenv (at least on macos - linux users can add instructions for that env, but should be very similar.)
…ck-format-all-files
|
We should have black-specific code quality checks in GHA workflows later. For now I think it is good enough if devs use the auto-formatting feature of their favorite IDE or Editor to ensure that files are always black-formatted when touched. Or one could always just enter |
…serted into the generated impl file
… error message where missing
|
This pull request fixes 1 alert when merging 981568a into 3390914 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 62b7b01 into 3390914 - view on LGTM.com fixed alerts:
|
|
Added support for using the official kb-sdk image. |
|
This pull request fixes 1 alert when merging 6d371b6 into 3390914 - view on LGTM.com fixed alerts:
|
…ck-format-all-files
|
This pull request fixes 1 alert when merging dd3f029 into 27eb4d9 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging d5a04ab into e519c8b - view on LGTM.com fixed alerts:
|
|
@scanon I've resolved the merge conflicts, added a simple make task, added configuration to exclude generated files or files copied into lib (clients). |
This PR simply applies the
blackPython formatter to all source files. This should help avoid git-commit-diff spam when devs do their due diligence to ensure that all source files well-formed. It also paves the way for putting in place additional code quality checks, including whether the source files are properly formatted.There are no functional changes to source files. Some cleanup was necessary after a merge from master which introduced merge conflicts, and the doc for pipenv usage was updated from an improved version from the SAM-96 work.
The formatting was done by simply installing the python dependencies locally using the
pipenvinstructions, then running the following commands, to format the code in the respective directories.black lib black test