Skip to content

DEVOPS-2030 Skip Cloudflare at Nersc#489

Merged
bio-boris merged 5 commits into
developfrom
DEVOPS-2030
Nov 4, 2024
Merged

DEVOPS-2030 Skip Cloudflare at Nersc#489
bio-boris merged 5 commits into
developfrom
DEVOPS-2030

Conversation

@bio-boris

@bio-boris bio-boris commented Nov 1, 2024

Copy link
Copy Markdown
Collaborator

Description of PR purpose/changes

ee2 was changed to send requests and avoid cloudflare, so send them on the internal network
The internal network is not accessible at nersc, so we have to send through cloudflare
These changes/hack modify the job runner to replace that URL when it is running at NERSC to the public URL
These changes are current deployed on production. You can run a hipmer job to prove it and see that they now run.
Corresponding changes in jobRunner are also deployed on production. kbase/JobRunner#87

Testing Instructions

  • Details for how to test the PR:
  • Tests pass in Github Actions and locally
  • Run a hipmer job

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/data-upload-project/development
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have run Black and Flake8 on changed Python Code manually or with git precommit (and the Github Actions build passes)

Updating Version and Release Notes (if applicable)

@bio-boris bio-boris changed the title DEVOPS-2030 DEVOPS-2030 Skip Cloudflare at Nersc Nov 1, 2024
@bio-boris bio-boris requested a review from Tianhao-Gu November 1, 2024 21:30
@bio-boris bio-boris marked this pull request as ready for review November 1, 2024 21:38

@Tianhao-Gu Tianhao-Gu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bio-boris bio-boris merged commit 3f7df4c into develop Nov 4, 2024
@bio-boris bio-boris deleted the DEVOPS-2030 branch November 4, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants