SECURITY-36 Mongo3.6/Mongo7 Matrix#484
Conversation
bio-boris
changed the title
bio-boris
changed the title
| - | ||
| name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 | ||
| - | ||
| name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| - | ||
| name: Build and push | ||
| uses: docker/build-push-action@v6 | ||
| with: | ||
| push: false | ||
| tags: ee2/test:test No newline at end of file |
There was a problem hiding this comment.
- Is QEMU setup necessary?
- format each step with spacing to make it easier to read. (optional)
There was a problem hiding this comment.
I copied this directly from https://github.com/docker/build-push-action
| @@ -0,0 +1,14 @@ | |||
| print("Adding travis username to ee2 database for mongo 7.0") | |||
| db = db.getSiblingDB('ee2') | |||
There was a problem hiding this comment.
We don't need this line db.auth('travis', 'travis') on mongo7
There was a problem hiding this comment.
Correct, it causes the init script to fail on mongo7
There was a problem hiding this comment.
Otherwise, I would be able to use the same script for mongo 3.6 and mongo 7, but I cannot. That's the whole point of using 2 different scripts.
| - "27017:27017" | ||
| volumes: | ||
| - "./test/dockerfiles/mongo/docker-entrypoint-initdb.d/:/docker-entrypoint-initdb.d/" | ||
| - ${INIT_PATH:-./test/dockerfiles/mongo/docker-entrypoint-initdb.d-7.0/}:/docker-entrypoint-initdb.d/ |
There was a problem hiding this comment.
INIT_PATH got mapped from the host machine into the container. Where are the files inside docker-entrypoint-initdb.d used?
There was a problem hiding this comment.
This allows you to use the docker-compose both locally and in github actions. In github actions, we set the INIT_PATH in the action. These files are used by mongo to create the proper users for testing.
|
Also, is Codecov being run properly? Is not displayed in the CI check. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## SECURITY-36-2 #484 +/- ##
================================================
Coverage ? 88.68%
================================================
Files ? 29
Lines ? 2740
Branches ? 0
================================================
Hits ? 2430
Misses ? 310
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
I added the codecov token @Xiangs18 |
* Testing upgrades * Update mongo version * Update python to 3.10.10 * Update ee2-tests.yml * SECURITY-36 Mongo3.6/Mongo7 Matrix (#484) * Linting * Bump version and release notes --------- Co-authored-by: Boris <bio-boris@github.com>
* Update RELEASE_NOTES.md * add dependabot.yml && fix .pre-commit-config.yaml file (#478) * add dependabot * fix pre-comit config * black format fix * flake8 fix * SECURITY-36 3.10.10 (#477) * Testing upgrades * Update mongo version * Update python to 3.10.10 * Update ee2-tests.yml * SECURITY-36 Mongo3.6/Mongo7 Matrix (#484) * Linting * Bump version and release notes --------- Co-authored-by: Boris <bio-boris@github.com> * Bump actions/setup-python from 4 to 5 in /.github/workflows (#481) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Sijie Xiang <xiangs18@bu.edu> Co-authored-by: Boris <bio-boris@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 participants
Description of PR purpose/changes