CDM-243: Add MFA state determination code to OrcID provider#498
Merged
Conversation
Based on code originally written by David Lyon here: #471
MrCreosote
commented
Nov 17, 2025
Member
Author
There was a problem hiding this comment.
@dauglyon there's a couple of changes from your code I should note:
- I removed the logging since the auth servier automatically logs any exception it gets.
- I made the exception messages less specific since they get displayed to the users and I was worried about some or all of the JWT winding up in the message, although I don't think that's super likely, but better safe than sorry. The entire exception will be logged, so the specific message will be available there
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #498 +/- ##
=============================================
+ Coverage 93.41% 93.44% +0.02%
Complexity 2181 2181
=============================================
Files 129 129
Lines 7629 7659 +30
Branches 1191 1200 +9
=============================================
+ Hits 7127 7157 +30
Misses 459 459
Partials 43 43 🚀 New features to boost your workflow:
|
dauglyon
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on code originally written by David Lyon here: #471