Fix Pages outage: add CNAME and bump deprecated workflow actions - #27
Merged
Conversation
The Apr 13 deploy run flagged Node 20 actions as deprecated. Bumping all actions to their current latest major versions which run on Node 24: - actions/checkout v4 -> v6 - actions/setup-python v4 -> v6 - actions/setup-node v4 -> v6 - actions/configure-pages v4 -> v6 - actions/upload-artifact v4 -> v7 - actions/download-artifact v4 -> v8 - actions/upload-pages-artifact v3 -> v5 - actions/deploy-pages v4 -> v5
The Python Scripts CI workflow has been failing because yakimavalleyhops.com started returning 403 to GitHub-runner IPs. Per the user's direction, drop the scraper from CI entirely and rely on the already-checked-in static dataset at website/public/data/hops.json for deploys. The deploy workflow consumes that file directly via the React build, so the live site is unaffected. If data needs refreshing in the future, the scrapers can be run locally and the result committed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The live site at
https://www.grontved.xyz/HopDatabase/was down. Root cause: Pages is configured with a custom domain, butactions/upload-pages-artifactreplaces the entire served site on every deploy, and the build artifact never contained aCNAMEfile — so the custom-domain binding eventually broke.website/public/CNAMEcontainingwww.grontved.xyz. CRA copiespublic/tobuild/verbatim, so the next deploy artifact will include it and Pages will re-bind the custom domain.actions/checkoutv4 → v6actions/setup-pythonv4 → v6actions/setup-nodev4 → v6actions/configure-pagesv4 → v6actions/upload-artifactv4 → v7actions/download-artifactv4 → v8actions/upload-pages-artifactv3 → v5actions/deploy-pagesv4 → v5Test plan
mainand confirm theDeploy React App to GitHub Pagesworkflow run completes bothbuildanddeployjobs successfullyhttps://www.grontved.xyz/HopDatabase/returns the React app (not 404 / Pages error)www.grontved.xyzshows as the custom domain with a green check and HTTPS enforcedworkflow_dispatch, confirmPython Scripts CIstill produces and uploads thehop_databaseartifact and creates the monthly release (covers the upload/download-artifact major-version bumps)Generated by Claude Code