Conversation
jvdd
commented
Dec 28, 2022
Comment on lines
-22
to
-26
| // https://stackoverflow.com/a/3793950 | ||
| #[cfg(target_arch = "x86_64")] | ||
| const MAX_INDEX: usize = 1 << f64::MANTISSA_DIGITS; | ||
| #[cfg(target_arch = "x86")] // https://stackoverflow.com/a/29592369 | ||
| const MAX_INDEX: usize = u32::MAX as usize; |
Owner
Author
|
Changed this to draft as this is less a priority at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles the index as a different SIMD dtype (ideally unsigned int) in the inner SIMD loop.
=> this should result in fewer exits of this loop to the surrounding "overflow-safe" code.
First benchmarking results show that the added performance gain is neglectable..
If this also shows minor / no improvements, than I'd rather not merge this PR (as it is not worth the added complexity).