chore: audit quality pass — silence bench prints on green runs; dedup isSensitivePath#605
Merged
Merged
Conversation
Unconditional stderr output mid test-protocol made zig build echo a 'failed command' banner on green runs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
One implementation for the security filter; #589 had to patch both copies in lockstep. The issue-528 parity test keeps guarding the API. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Benchmark Regression ReportThresholds: 10.00% and 50,000 ns absolute delta
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small cleanups out of today's audit sweep:
test_bench perf prints gated behind
CODEDB_BENCH_VERBOSE. The two unconditionalstd.debug.printcalls wrote to stderr mid test-protocol, which madezig build testecho afailed command: ...banner on fully green runs (the long-standing cosmetic annoyance in the session notes). Verified gone after gating; setCODEDB_BENCH_VERBOSE=1to get the numbers back.watcher.isSensitivePathnow delegates tosnapshot.isSensitivePathinstead of carrying a byte-identical 44-line copy. watcher/snapshot: isSensitivePath misses OpenSSH default key names id_ecdsa, id_dsa, and *_sk FIDO variants #589 had to patch both copies in lockstep; now there is one implementation. Theissue-528: isSensitivePath paritytest still runs against both pub fns, and no import cycle is introduced (snapshot.zig does not import watcher.zig).No behavior change in either filter or bench.
Test plan
zig build test— 23/23 steps, 807/807 tests passedzig build test 2>&1 | grep -c "failed command"→ 0 (was 1)🤖 Generated with Claude Code