chore(cli): log why a word.index disk load was skipped#567
Merged
Conversation
loadWordIndexFromDiskIfPresent silently disabled the disk load on any mismatch (no header / file_count / git head / mmap+read failure), leaving the next query to pay a full heap rebuild with no breadcrumb — it reads as an unexplained RSS/latency spike when profiling. Debug-level logs name the reason at each disable site. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Benchmark Regression ReportThresholds: 10.00% and 50,000 ns absolute delta
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while chasing a phantom +213MB daemon RSS jump (which turned out to be cold-page-cache mmap fault-in, not a heap leak):
loadWordIndexFromDiskIfPresentdisables the disk load silently on any mismatch, so a fallback to full heap rebuild has no breadcrumb. Debug-level logs now name the reason (no header / file_count mismatch / git-head mismatch / mmap+read failure) at each disable site.No behavior change; suite green.
🤖 Generated with Claude Code