Skip to content

5.x.x: Update validate-json to use spl_autoload_register - #589

Merged
erayd merged 1 commit into
jsonrainbow:5.x.xfrom
sanmai:patch-1
Sep 23, 2019
Merged

5.x.x: Update validate-json to use spl_autoload_register#589
erayd merged 1 commit into
jsonrainbow:5.x.xfrom
sanmai:patch-1

Conversation

@sanmai

@sanmai sanmai commented Sep 23, 2019

Copy link
Copy Markdown

Fixes #574

@sanmai sanmai changed the title Update validate-json to use spl_autoload_register 5.x.x: Update validate-json to use spl_autoload_register Sep 23, 2019

@erayd erayd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this one merging directly into 5.x.x, as the relevant code has diverged from v6.

@erayd
erayd merged commit e8b7614 into jsonrainbow:5.x.x Sep 23, 2019
@erayd

erayd commented Sep 23, 2019

Copy link
Copy Markdown
Contributor

Thank you @sanmai :-).

@maks-rafalko

Copy link
Copy Markdown

Guys, could you please tag a new release with this fix?

@erayd

erayd commented Sep 23, 2019

Copy link
Copy Markdown
Contributor

@maks-rafalko Yes. I want to roll a few other backported fixes in too.

@sanmai
sanmai deleted the patch-1 branch September 24, 2019 01:07
@sanmai

sanmai commented Sep 25, 2019

Copy link
Copy Markdown
Author

A release with just this fix will be very appreciated because it is a major deprecation since PHP 7.2. Almost everyone these days is getting PHP 7.3 from the start, e.g. because Debian stable includes one. Thank you very much for considering this request.

@erayd

erayd commented Sep 25, 2019

Copy link
Copy Markdown
Contributor

@sanmai Are you requesting a release ASAP, or are you specifically wanting a release with that fix only in it? Because I'm doing the backports now, and should be tagging stuff in a few minutes.

@erayd erayd mentioned this pull request Sep 25, 2019
erayd added a commit that referenced this pull request Sep 25, 2019
## Backported PRs
 * #559 ArraysTest for array items with enum validation
 * #567 Don't run checks which assume a defined instance against undefined
 * #575 Tests on PHP 7.3
 * #587 Fixed PHPDoc of Validator::validate() method
 * #583 Fix travis PHP 5.4 and 5.5 config

## Additional PRs (5.x.x only)
These PRs are only applicable to the 5.x.x branch, and have been merged individually.
 * #589 Update validate-json to use spl_autoload_register

## Skipped PRs
 * #464 marc-mabe/php-enum versions (dependency not present in 5.x.x)
@erayd

erayd commented Sep 25, 2019

Copy link
Copy Markdown
Contributor

@maks-rafalko I've just tagged v5.2.9 with all current backports merged in.

@sanmai Please let me know if you need an additional release that contains only the autoload fix - that seems like a rather strange thing to ask for, so I'd prefer not to do it without a good reason.

@maks-rafalko

Copy link
Copy Markdown

Thank you!

@sanmai

sanmai commented Sep 25, 2019

Copy link
Copy Markdown
Author

Please let me know if you need an additional release that contains only the autoload fix

This wasn't necessary absolutely. I meant that if you're busy with other things tagging a release with just this fix would be a big help. But else any release works. Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants