Coerce empty string to null - #381
Conversation
| if ($coerce) { | ||
| $value = $this->toNull($value); | ||
| } | ||
| return is_null($value); |
There was a problem hiding this comment.
Need a newline above return is_null($value); to make the style checker happy.
| "object":{}, | ||
| "array":[], | ||
| "null":null, | ||
| "null":"", |
There was a problem hiding this comment.
I notice that you have lots of explicit tests in testValidCoerceCases, in addition to simply requiring the schema to validate, but that null coercion hasn't been added as one of them. Is there a reason for that?
There was a problem hiding this comment.
I don't understand. Can you provide an example?
I believe I originally created this file by duplicating BasicTypesTest.
There was a problem hiding this comment.
Ohhh, I think I get what you mean. One sec...
There was a problem hiding this comment.
Added a post-validate test for null.
I also removed what looked like a duplicated block of explicit tests in the same section of code. Not sure if there was any purpose for it...
| if ($coerce) { | ||
| $value = $this->toNull($value); | ||
| } | ||
|
|
There was a problem hiding this comment.
The newline is good, but need to remove the unneeded whitespace on this line.
|
I think we're good - thanks for doing this PR :-). |
|
Right you are. Closing... |
3 participants
Fix for the null coercion portion of #379
Coerce empty sting to null for type "null".
@erayd @bighappyface @gtuccini