Extend CSS color support with css-color module#171
Merged
domenic merged 6 commits intojsdom:mainfrom Dec 20, 2024
Merged
Conversation
5b1ab13 to
20eb33a
Compare
4bdf341 to
dce39da
Compare
Contributor
Author
|
PR ready. |
cd7a423 to
5ed595f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, support for CSS colors is very limited.
The css-color module covers most of the colors in CSS color module level 4.
NOTE: Colors are converted to
specified value, notcomputed value.NOTE2: In the test, caching seems to be working.
For this reason, I think the elapsed time displayed in test results are not so reliable.
If I add the same test, elapsed time significantly decreased.
Fixes #134, fixes #135, fixes #136, fixes #174