Fix review drift: exceptions, model defaults, dead code, stale docs#11
Open
joy-void-joy wants to merge 18 commits into
Open
Fix review drift: exceptions, model defaults, dead code, stale docs#11joy-void-joy wants to merge 18 commits into
joy-void-joy wants to merge 18 commits into
Conversation
958336b to
7a6757d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup pass resolving drift found in review:
except Exceptionhandlers to specific types and annotate the intentionally-broad guards with justificationsclaude-opus-4-6Any-typed MCP plumbing withMcpServerConfig/SdkMcpTool, key servers by name, generate tool docs from SDK tool definitions instead ofgetattrduck-typinglogs_pathsetting, and construction-only testslup.lib.*module paths, README devtools listing, CLAUDE.md structure drift; drop the PLAN.md conventionsh-based clipboard, shippy.typedin the lup packageCommits
chore: gitignore .lup runtime directorychore(lup): ship py.typed markerrefactor(lup): remove unused session-listing helpersrefactor(lup): remove unused timestamp helpersrefactor: tighten broad exception handlersfix: default all model choices to claude-opus-4-6fix(agent): key MCP servers by name in get_mcp_serversrefactor(agent): generate tool docs from SDK tool definitionsfix(devtools): disable usage watch mode outside a terminalrefactor(devtools): replace subprocess clipboard with shrefactor(devtools): remove unused charts modulerefactor(agent): remove unused logs_path settingtest: remove construction testsdocs: fix stale module paths in docstringsdocs(readme): fix devtools listing and truncated commandsmeta: drop PLAN.md conventionmeta(claude-md): align docs with actual code structuremeta(commands): delegate fb-investigate trace reading to trace-explorerTest plan
uv run lup-devtools dev check— ruff format, ruff check, pyright, pytest all pass