Stop tracking .claude/settings.local.json - #247
Merged
Conversation
Being tracked defeats the point of a *.local.* file: every fresh worktree spawn where Claude Code rewrites this file's local permission state diverges from the committed version, so git status is never clean on a brand-new worktree. This silently trips any hard-stop that checks for a clean working tree (e.g. dev-team:watch-pr's step 1 worktree-freshness check) on every single spawn. Already covered by the existing *.local.* gitignore pattern - just needed to be untracked. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NhMgWJeN4ytrcZdaWZYgqY
jodavis
enabled auto-merge (rebase)
July 27, 2026 23:51
jodavis
approved these changes
Jul 27, 2026
Test Results401 tests ±0 401 ✅ ±0 2m 31s ⏱️ +26s Results for commit da86708. ± Comparison against base commit 8f1b8b7. This pull request removes 3 and adds 2 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/settings.local.jsonwas committed to git despite the.local.naming convention (and existing*.local.*gitignore pattern) marking it as machine-local state.git statusis never clean on a brand-new worktree.dev-team:watch-pr's step 1 worktree-freshness hard-stop (and any other check expecting a clean tree) on essentially every spawn — discovered while multiple agents got stuck unable to start monitoring PR ADR-338: Wire mypy --strict static analysis into ml/ build #246 for ADR-338.Test plan
git check-ignore --no-indexmatches the file against the existing*.local.*pattern, so no.gitignorechanges are needed.git worktree addshows a cleangit status --short.🤖 Generated with Claude Code
https://claude.ai/code/session_01NhMgWJeN4ytrcZdaWZYgqY