Add support for Terraform package type #354#380
Merged
Merged
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
eyalbe4
self-requested a review
September 28, 2023 02:10
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
yahavi
added
improvement
yahavi
added
safe to test
github-actions
Bot
removed
the
safe to test
github-actions
Bot
removed
the
safe to test
yahavi
requested changes
Nov 7, 2023
|
|
||
| @Override | ||
| RepositorySettings getRepositorySettings(RepositoryType repositoryType) { | ||
|
|
Comment on lines
+23
to
+51
| if (repositoryType == RepositoryTypeImpl.REMOTE) { | ||
| def settings = new TerraformRepositorySettingsImpl() | ||
| settings.with { | ||
| repoLayout = defaultLayout | ||
| vcsType = VcsType.GIT | ||
| vcsGitProvider = VcsGitProvider.GITHUB | ||
| terraformRegistryUrl = "https://registry.terraform.io" | ||
| terraformProvidersUrl = "https://releases.hashicorp.com" | ||
| remoteRepoLayoutRef = defaultLayout | ||
| } | ||
| return settings | ||
| } | ||
|
|
||
| if (repositoryType == RepositoryTypeImpl.VIRTUAL) { | ||
| def settings = new TerraformRepositorySettingsImpl() | ||
| settings.with { | ||
| repoLayout = moduleLayout | ||
| } | ||
| return settings | ||
| } | ||
|
|
||
| if (repositoryType == RepositoryTypeImpl.FEDERATED) { | ||
| def settings = new TerraformRepositorySettingsImpl() | ||
| settings.with { | ||
| terraformType = TerraformRepositorySettings.TerraformType.module | ||
| repoLayout = moduleLayout | ||
| } | ||
| return settings | ||
| } |
| import org.jfrog.artifactory.client.model.repository.settings.vcs.VcsGitProvider; | ||
| import org.jfrog.artifactory.client.model.repository.settings.vcs.VcsType; | ||
|
|
||
| public interface TerraformRepositorySettings extends RepositorySettings{ |
Member
There was a problem hiding this comment.
Suggested change
| public interface TerraformRepositorySettings extends RepositorySettings{ | |
| @JsonIgnoreProperties(ignoreUnknown = true) | |
| public interface TerraformRepositorySettings extends RepositorySettings { |
|
|
||
| public interface TerraformRepositorySettings extends RepositorySettings{ | ||
|
|
||
| // local and federated settings |
Member
There was a problem hiding this comment.
Let's capitalize all new comments
Suggested change
| // local and federated settings | |
| // Local and federated settings |
- Changes based on PR jfrog#380 feedback
github-actions
Bot
removed
the
safe to test
yahavi
added
new feature
github-actions
Bot
removed
the
safe to test
yahavi
approved these changes
Nov 8, 2023
Member
|
@nevenr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review.
Thanks.
Regards,
N