Fix options parsing - ensuring that TOKEN_PATH and TOKEN_XXX aren't mixed#367
Merged
davidcollom merged 1 commit intomainfrom Apr 29, 2025
Merged
Fix options parsing - ensuring that TOKEN_PATH and TOKEN_XXX aren't mixed#367davidcollom merged 1 commit intomainfrom
davidcollom merged 1 commit intomainfrom
Conversation
davidcollom
requested review from
aidy,
joshw123,
maria-reynoso and
paulwilljones
davidcollom
force-pushed
the
fix-options-parsing
branch
2 times, most recently
from
1ad4944 to
5911513
Compare
davidcollom
force-pushed
the
fix-options-parsing
branch
from
5911513 to
2e23362
Compare
davidcollom
commented
Apr 28, 2025
| } | ||
| } | ||
|
|
||
| regexActions := map[*regexp.Regexp]func(matches []string, value string){ |
Collaborator
Author
There was a problem hiding this comment.
Go maps iterate in random order, so by using a slice to ensure consistency, adding the two problematic options/regex's at the top/start of the slice
This was referenced Apr 28, 2025
joshw123
approved these changes
Apr 29, 2025
davidcollom
pushed a commit
that referenced
this pull request
Apr 29, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.