Skip to content

Test Bugfix: make BootSourceTest#doCheckImageIdWhenNoValueSet assertion locale indepent#329

Closed
Farix1337 wants to merge 4 commits intomasterfrom
unknown repository
Closed

Test Bugfix: make BootSourceTest#doCheckImageIdWhenNoValueSet assertion locale indepent#329
Farix1337 wants to merge 4 commits intomasterfrom
unknown repository

Conversation

@Farix1337
Copy link
Copy Markdown

@Farix1337 Farix1337 commented Sep 16, 2021

If running the jenkins.plugins.openstack.compute.slaveopts.BootSourceTest#doCheckImageIdWhenNoValueSet at a machine without US or GB localisation the assertion will fail, because the created VALIDATION_REQUIRED which is used for the expect value changes based on the jvm default java.util.Locale (See the Implementation org.jvnet.localizer.ResourceBundleHolder#format)
This changes forces the US Localisation for the creation of the expected value of VALIDATION_REQUIRED.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Farix1337
Copy link
Copy Markdown
Author

Currently the build is failing because plugins for a lower jenkins version than 2.235.4 can't be build.
I am working with @frkautz and @MintInfusion to fix this issue.
This Pull Request is just prep work for our next Pull Request to allow the usage of multifacor authenticated openstack apis.

@Farix1337
Copy link
Copy Markdown
Author

Due to neceassry jenkins version update commits which poluted this Pull request i close this Pull Request and make a new one for updating the jenkins version: #331

@Farix1337 Farix1337 closed this Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants