set CMAKE_POSITION_INDEPENDENT_CODE if BUILD_SHARED_LIBS=OFF

[christian-rauch]

No description provided.

[gelldur]

This will set PIC for all targets (what if someone adds library as sub-directory, maybe set_property would be better?
set_property(TARGET lib1 PROPERTY POSITION_INDEPENDENT_CODE ON)

[christian-rauch]

If BUILD_SHARED_LIBS=OFF then every library, that hasn't explicitly set SHARED or STATIC will build as STATIC. I think that PIC should therefore apply to all static libraries that the cmake project builds.

[milipili]

Property on targets should be used instead. It is not rare that CMake projects are included into another, and deciding to set CMAKE_POSITION_INDEPENDENT_CODE will just break everything.

It should always be per target. Also why setting position indepdendant code if building a static library? In many cases we dont want that option. Only if it is included into a bigger shared library

[christian-rauch]

In many cases we dont want that option.

Why? You will need that option if you want to link your static library into an executable a shared library. Is there a downside of using this in executables too? AFAIK, all modern Linux distributions use position-independent-executables now.

[christian-rauch]

Property on targets should be used instead.

I set this for the target yaml-cpp only. I think this is the only target in the project.

[jbeder]

Fixes #1031