Skip to content

[.github/workflows/build.yml] enable to run of test at the 'windows-latest' environment.#1074

Merged
jbeder merged 1 commit intojbeder:masterfrom
TheVice:msvc
Dec 15, 2021
Merged

[.github/workflows/build.yml] enable to run of test at the 'windows-latest' environment.#1074
jbeder merged 1 commit intojbeder:masterfrom
TheVice:msvc

Conversation

@TheVice
Copy link
Copy Markdown
Contributor

@TheVice TheVice commented Dec 15, 2021

Hello.

This request fix all know issues that was detected while run pipeline at the Windows platform:

  • dll was not placed near to the test binary, so ctest tool could not execute a binary;
  • used std::isspace with non 'unsigned char' type of argument do not pass assert check at MSVC environment, but such casting should be provided for all environments according to documentation on that function.

This request partially replace #1057 - only enabling to run at macOS left there.

Thank you.

to the output directory with a test binary.

[binary] removed using of non unsigned char as argument at
'std::isspace' function that was provokes undefined behavior.

[.github/workflows/build.yml] enabled run of test at the
'windows-latest' environment.
@jbeder jbeder merged commit d8d9419 into jbeder:master Dec 15, 2021
@TheVice TheVice deleted the msvc branch December 16, 2021 01:45
davemccann pushed a commit to davemccann/yaml-cpp that referenced this pull request Jul 30, 2023
Add copying of shared library to the output directory with a test binary.

[binary] removed using of non unsigned char as argument at
'std::isspace' function that was provokes undefined behavior.

[.github/workflows/build.yml] enabled run of test at the
'windows-latest' environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants