Open
Conversation
- Added length check before accessing topics.Messages slice - Prevents panic when topics.Messages is empty (length 0) - Fixes 'index out of range [-1]' error in fetchTopics function The bug occurred at line 286 where topics.Messages[len(topics.Messages)-1] was accessed without checking if the slice was empty first. When the slice is empty, len-1 equals -1, causing a panic. Fixes iyear#1122
Contributor
Author
|
I think I need to update the documentation too but I don't know how to do it so let me know if you can do it or if I have to do it |
Owner
|
I prefer to use the |
Contributor
Author
|
so the feature already exists? |
Contributor
Author
|
@iyear hello? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Add filter to download files by size
Description
This PR addresses issue #1119 by adding the ability to filter downloads based on file size. It introduces two new flags to the
downloadcommand:--min-sizeand--max-size.Changes
1. New Utility: ParseBinaryBytes
2. Core Implementation
MinSizeandMaxSizefields to the Options struct.3. CLI Updates
--min-sizeand--max-sizeflags to the dl command.Usage Example
Verification