Skip to content

redirect shoud be child filed of HTTPRoute - #839

Closed
idouba wants to merge 3 commits into
istio:masterfrom
idouba:master
Closed

redirect shoud be child filed of HTTPRoute#839
idouba wants to merge 3 commits into
istio:masterfrom
idouba:master

Conversation

@idouba

@idouba idouba commented Mar 8, 2019

Copy link
Copy Markdown
Member

No description provided.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 8, 2019
@istio-testing

Copy link
Copy Markdown
Collaborator

Hi @idouba. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rshriram

Copy link
Copy Markdown
Member

/lgtm

@istio-testing

Copy link
Copy Markdown
Collaborator

@rshriram: changing LGTM is restricted to assignees, and assigning you to the PR failed.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andraxylia

Copy link
Copy Markdown
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Mar 11, 2019
@andraxylia

Copy link
Copy Markdown
Contributor

Please fix circleci failure.

@andraxylia

Copy link
Copy Markdown
Contributor

Repo has unstaged changes. Re-run ./scripts/generate-protos.sh

@idouba

idouba commented Mar 18, 2019

Copy link
Copy Markdown
Member Author

/retest

@hzxuzhonghu

Copy link
Copy Markdown
Member

/lgtm

@istio-testing

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, idouba, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing

Copy link
Copy Markdown
Collaborator

@hzxuzhonghu: changing LGTM is restricted to assignees, and only istio/api repo collaborators may be assigned issues.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@idouba

idouba commented Mar 19, 2019

Copy link
Copy Markdown
Member Author

Repo has unstaged changes. Re-run ./scripts/generate-protos.sh

@andraxylia Done, pls help review it , thanks.

@geeknoid

Copy link
Copy Markdown
Contributor

@andraxylia Are we good to merge this?

If so, can you create a cherry pick to the release-1.1 branch?

Thanks.

@linsun

linsun commented Mar 19, 2019

Copy link
Copy Markdown
Member

think this is already covered by #865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants