Add option to select worload using lables for authn policy. - #755
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
|
Should this go to 1.1 branch or are you planning to merge this after master is unblocked? |
rshriram
reviewed
Jan 14, 2019
geeknoid
approved these changes
Jan 14, 2019
Contributor
|
/lgtm |
Contributor
Author
|
@hklai, can we have this merge to master to have some implementation started. Thanks. |
Contributor
|
@diemtvu perhaps not until it is unlocked. we don't want significant divergence between 1.1 and master. |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: costinm, diemtvu, ozevren The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/test api-presubmit |
hklai
added a commit
that referenced
this pull request
Jan 19, 2019
* assorted doc updates (#757) Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * add optional incremental flag to ResponseSink and ResourceSource services (#762) * Add option to select worload using lables for authn policy. (#755) * Add option to select workload using labels for authn policy * Make proto-commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prep work to use label selector for authentication. Selector using service name will be converted to labels internally.