This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Reviews#137
Merged
forest merged 2 commits intoirphilli:masterfrom Jun 4, 2020
Merged
Conversation
added 2 commits
June 3, 2020 12:12
…le for recent versions of Mocha. Semantic versioning cannot be evaluated by greater than/less than comparisons i.e 1.11 is less than 1.9 as floats but not as semantic versions. Reverting to original require syntax as this appears to be the valid syntax for most recent versions of Mocha. Deprecation warnings squelched by the original commit seem more tenable than additional logic in the test helper.
A review_type is tightly coupled to a review. It is accessible as a field customization for reviews but not accessible via a distinct api endpoint. Since it is difficult to understand a review without the review_type, I made the decision to include default review fields and review_type when calling get story/{story_id}/ reviews. The review types are hydrated automatically.
Contributor
|
@dipolesource looks good. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Reviews via
GET /projects/{project_id}/stories/{story_id}/reviews