This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Feature/adding file attachments#108
Merged
forest merged 3 commits intoirphilli:masterfrom Aug 14, 2017
Merged
Conversation
Closed
s-ashwinkumar
force-pushed
the
feature/adding_file_attachments
branch
from
215d569 to
fc8776e
Compare
Contributor
|
Thanks for contributing. I've been swamped but will get to this in the next week or so. |
Contributor
Author
|
@forest Thank you for letting me know ! |
forest
suggested changes
Jul 18, 2017
Contributor
forest
left a comment
forest
left a comment
There was a problem hiding this comment.
Thanks for this addition. Lots of work and I'm sure will be appreciated by many.
| Resources::FileAttachment.new({ comment: comment }.merge(data)) | ||
| end | ||
|
|
||
| # This orphans the file, deletes source, but appears in the comments |
Contributor
There was a problem hiding this comment.
Can we remove the commented out code?
You can put TODOs or notes in comments at the top of the class if you want.
Contributor
Author
There was a problem hiding this comment.
@forest Thank you. Sorry, for some weird reason I never got any notifications. Let me get to these this week. Will convert this to TODO
| @@ -0,0 +1,16 @@ | |||
| module TrackerApi | |||
| class FileUtility | |||
Contributor
There was a problem hiding this comment.
Please fix this white space.
| # File.open(filename, 'wb') { |fp| fp.write(file_data) } | ||
| # end | ||
|
|
||
| def to_upload_hash |
Contributor
Author
|
@forest handled the CR changes. Thank you and sorry for the delay. |
Contributor
|
No problem. Thanks.
…On Mon, Aug 14, 2017 at 11:37 AM s-ashwinkumar ***@***.***> wrote:
@forest <https://github.com/forest> handled the CR changes. Thank you and
sorry for the delay.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#108 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAelcc66AxVncegllA_LDoVGUuXrsU2ks5sYJPNgaJpZM4N2p11>
.
|
forest
approved these changes
Aug 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please let me know about any corrections. I have tried to follow the same pattern as it is currently.