Skip to content

[DW-29] stop using CloneAs in GetPixelColor #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
first-ironsoftware merged 1 commit into from
Feb 20, 2025
Merged

[DW-29] stop using CloneAs in GetPixelColor #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added IronSoftware.Drawing/IronSoftware.Drawing.Common.Tests/Data/google_large_1500dpi.bmp
View file
Open in desktop
Binary file not shown.
30 changes: 30 additions & 0 deletions IronSoftware.Drawing/IronSoftware.Drawing.Common.Tests/UnitTests/AnyBitmapFunctionality.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,36 @@ public void AnyBitmap_should_ToString()
Assert.Equal(expected, result);
}

[FactWithAutomaticDisplayName]
public void AnyBitmap_GetPixel_should_not_throw_OutOfMemoryException()
{
//Should not throw exception
//previously GetPixel always called CloneAs() which resulted to OutOfMemoryException
string imagePath = GetRelativeFilePath("google_large_1500dpi.bmp");
using Image<Rgb24> formatRgb24 = Image.Load<Rgb24>(imagePath);
using Image<Abgr32> formatAbgr32 = Image.Load<Abgr32>(imagePath);
using Image<Argb32> formatArgb32 = Image.Load<Argb32>(imagePath);
using Image<Bgr24> formatBgr24 = Image.Load<Bgr24>(imagePath);
using Image<Bgra32> formatBgra32 = Image.Load<Bgra32>(imagePath);

Image[] images = { formatRgb24, formatAbgr32, formatArgb32, formatBgr24, formatBgra32 };

foreach (Image image in images)
{
AnyBitmap bitmap = (AnyBitmap)image;

int hash = 0;
for (int y = 0; y < bitmap.Height; y += 8)
{
for (int x = 0; x < bitmap.Width; x += 8)
{
var pixel = bitmap.GetPixel(x, y);
hash += pixel.ToArgb();
}
}
}
}

[FactWithAutomaticDisplayName]
public void Clone_AnyBitmap()
{
Expand Down
51 changes: 29 additions & 22 deletions IronSoftware.Drawing/IronSoftware.Drawing.Common/AnyBitmap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2545,29 +2545,36 @@ private static void ConvertRGBAtoBGRA(byte[] data, int width, int height, int sa

private Color GetPixelColor(int x, int y)
{
if (Image is Image<Rgb24>)
{
return (Color)Image.CloneAs<Rgb24>()[x, y];
}
else if (Image is Image<Abgr32>)
{
return (Color)Image.CloneAs<Abgr32>()[x, y];
}
else if (Image is Image<Argb32>)
{
return (Color)Image.CloneAs<Argb32>()[x, y];
}
else if (Image is Image<Bgr24>)
{
return (Color)Image.CloneAs<Bgr24>()[x, y];
}
else if (Image is Image<Bgra32>)
{
return (Color)Image.CloneAs<Bgra32>()[x, y];
}
else
switch (Image)
{
return (Color)Image.CloneAs<Rgba32>()[x, y];
case Image<Rgba32> imageAsFormat:
return imageAsFormat[x, y];
case Image<Rgb24> imageAsFormat:
return imageAsFormat[x, y];
case Image<Abgr32> imageAsFormat:
return imageAsFormat[x, y];
case Image<Argb32> imageAsFormat:
return imageAsFormat[x, y];
case Image<Bgr24> imageAsFormat:
return imageAsFormat[x, y];
case Image<Bgra32> imageAsFormat:
return imageAsFormat[x, y];
case Image<Rgb48> imageAsFormat:
return imageAsFormat[x, y];
case Image<Rgba64> imageAsFormat:
return imageAsFormat[x, y];
default:
//Fallback

//We didn't have Converter to IronSoftware.Drawing.Color for other pixel format
//A8, L8, L16, La16, Bgr565, Bgra4444, RgbaVector

//CloneAs() is expensive!
//Can throw out of memory exception, when this fucntion get called too much
using (Image<Rgb24> converted = Image.CloneAs<Rgb24>())
{
return converted[x, y];
}
}
}

Expand Down