Add Point to MeasurementUnit Enum#123
Merged
ikramulhaque-iron merged 1 commit intodevelopfrom Jan 9, 2025
Merged
Conversation
ikkyuland
reviewed
Jan 9, 2025
Member
ikkyuland
left a comment
There was a problem hiding this comment.
need to update
public Rectangle ConvertTo(MeasurementUnits units, int dpi = 96) too right?
Member
|
Nice! thanks for add unit-tests and update doc! Sorry, could you please also update RectangleF class too? |
4cf3304 to
9d5e9df
Compare
ikkyuland
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Make sure the title of the PR is descriptive and summarizes the changes made.
Description
Model
IronSoftware.Drawing.Rectanglecontains a Property namedMeasurementUnit. This MeasurementUnit enum contains only 2 values. (Pixel and Millimeters). And the default value is considered as Pixel. But, in PDF we use another type of Measurement unit which is called Point (1 Point = 1 Inch / 72). So we have to add one more enum value Point to the MeasurementUnit enum.Fixes #(PDF-1489)
Fixes #(PDF-1689)
If this PR addresses an existing issue, mention the issue number here.
Type of change
Please select the relevant option by placing an 'x' inside the brackets, like this: [x].
How Has This Been Tested?
Describe the tests you ran to verify your changes. Provide instructions so others can reproduce the tests. Also, list any relevant details for your test configuration.
Checklist:
Please run through the checklist as much as possible and mark the items completed by placing an 'x' inside the brackets, like this: [x].
Additional Context
Add any other context, screenshots, or information about the pull request here.