[master] Prepare for December release#122
Merged
mee-ironsoftware merged 19 commits intomasterfrom Nov 28, 2024
Merged
Conversation
remove netstandard2.1 build; only test net472/net80
ref common and use anyimage update commons update commons fixup fixup fixup fixup
update commons and image sharp Co-authored-by: djrecipe <brkfstmnchr@gmail.com> Co-authored-by: mee-ironsoftware <mee@ironsoftware.com>
Cleanup .NET Framework Targets
update commons update drawing ver update drawing ver ROLL ROLL
[develop] IronDrawing Release/2024.9 [Do not merge until the product is released]
…ageSharp-for-vulnerability-issue [DW-27] Update SixLabour.ImageSharp due to vulnerability report
update commons update drawing ver update drawing ver ROLL ROLL
…oftware/IronSoftware.System.Drawing into provide-simple-interfaces # Conflicts: # IronSoftware.Drawing/IronSoftware.Drawing.Common/IronSoftware.Drawing.Common.csproj # NuGet/IronSoftware.Drawing.nuspec
# Conflicts: # NuGet/IronSoftware.Drawing.nuspec
first-ironsoftware
suggested changes
Nov 14, 2024
Contributor
first-ironsoftware
left a comment
first-ironsoftware
left a comment
There was a problem hiding this comment.
Please kindly see my comments for a few changes.
IronSoftware.Drawing/IronSoftware.Drawing.Common.Tests/IronSoftware.Drawing.Common.Tests.csproj
Outdated
Show resolved
Hide resolved
| <Platforms>AnyCPU</Platforms> | ||
| <SignAssembly>true</SignAssembly> | ||
| <TargetFrameworks>netstandard2.0;netstandard2.1;net60</TargetFrameworks> | ||
| <TargetFrameworks>netstandard2.0;net60</TargetFrameworks> |
Contributor
There was a problem hiding this comment.
I'm just curious. Why is netstandard2.1 removed?
Member
Author
There was a problem hiding this comment.
netstandard2.1 similar to netstandard2.0 you can check out netstandard2.0 and netstandard2.1
| <packageSources> | ||
| <clear /> | ||
| <add key="nuget.org" value="https://api.nuget.org/v3/index.json" /> | ||
| <add key="Common" value="https://pkgs.dev.azure.com/ironcoders/IronCommon/_packaging/IronCommon/nuget/v3/index.json" /> |
Contributor
There was a problem hiding this comment.
Does this cause issue to the customer endpoint when they need to use the package since they have no access to https://pkgs.dev.azure.com/ironcoders/IronCommon/_packaging/IronCommon/nuget/v3/index.json?
Member
Author
There was a problem hiding this comment.
We have IronSoftware.Drawing.Abstractions which will publish to nuget. But this using when we develop internal.
… of IronSoftware.Common
* Update CropRectangle in README * Updates /NuGet CropRectangle to Rectangle * Added missing XML tag to Legacy Class
mee-ironsoftware
force-pushed
the
releases/2024.12
branch
from
27473e7 to
1470b37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use IronSoftware.Drawing.Abstractions instead of IronSoftware.Common
Fixes N/A
Type of change
Please select the relevant option by placing an 'x' inside the brackets, like this: [x].
How Has This Been Tested?
Run PR Validation and Deployment pipeline.
Checklist:
Please run through the checklist as much as possible and mark the items completed by placing an 'x' inside the brackets, like this: [x].