IronDrawing - Convert Bitmap to AnyBitmap throws System.InvalidCastException#107
Merged
first-ironsoftware merged 8 commits intodevelopfrom Jun 17, 2024
Conversation
mee-ironsoftware
previously requested changes
Jun 12, 2024
Member
mee-ironsoftware
left a comment
There was a problem hiding this comment.
Please check out my comment.
IronSoftware.Drawing/IronSoftware.Drawing.Common.Tests/UnitTests/AnyBitmapFunctionality.cs
Outdated
Show resolved
Hide resolved
…bitmap-throw-system-invalid-cast-exception
I only dismiss this change request because Meee already confirmed that if this has been changed, the PR can be merged. Also he's on leave at the moment which prevent him from approving the change made further
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
IronDrawing converts bitmap to AnyBitmap throws system invalid cast exception
Description
When using
Convert.ChangeTypeto convert other bitmap formats to AnyBitmap, need to implement the IConvertible interface. However, I converted the other bitmap formats to System.Drawing.Bitmap and directly assigned into AnyBitmap.Fixes #(issue number)
[DW - 11] IronDrawing - Convert Bitmap to AnyBitmap throws System.InvalidCastException
Type of change
Please select the relevant option by placing an 'x' inside the brackets, like this: [x].
How Has This Been Tested?
RUN IronDrawing PR Validation
Checklist:
Please run through the checklist as much as possible and mark the items completed by placing an 'x' inside the brackets, like this: [x].