Use new serialization code for PyPy3.10+ 7.3.19+#934
Merged
minrk merged 2 commits intoipython:mainfrom Mar 4, 2025
Merged
Conversation
Enable the new `inspect.signature(types.CodeType)` code path for PyPy3.10 7.3.19 and newer, notably including PyPy3.11 that does not work with the fallback code anymore. Add a workaround to skip the `magic` parameter that does not seem to be exposed (or needed). With these changes, the serialization tests pass on PyPy3.11 7.3.19, as well as most of the test suite. Fixes ipython#933 Signed-off-by: Michał Górny <mgorny@gentoo.org>
mgorny
changed the title
types.CodeType serialization for PyPy3.11
for more information, see https://pre-commit.ci
Member
|
Excellent, thank you! |
Contributor
Author
|
Thanks! |
tgbugs
added a commit
to tgbugs/cloudpickle
that referenced
this pull request
Apr 26, 2025
See also two other places this has been fixed: ipython/ipyparallel#934 uqfoundation/dill#707
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the new
inspect.signature(types.CodeType)code path for PyPy3.10 7.3.19 and newer, notably including PyPy3.11 that does not work with the fallback code anymore. Add a workaround to skip themagicparameter that does not seem to be exposed (or needed).With these changes, the serialization tests pass on PyPy3.11 7.3.19, as well as most of the test suite.
Fixes #933