This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fix(cli): Tell user to init repo if not initialized when starting daemon#633
Merged
Conversation
Closed
Member
Author
|
@diasdavid tests were failing because 1) I set the timeout to one second while Travis is a lot slower to run than that, so removed my manual timeout to use the default one instead, 2) Sauce Labs can't authenticate if the branch comes from a fork, so I had to push the branch to ipfs/js-ipfs instead (opened issue in aegir about this here: ipfs/aegir#76 ) So now everything should work, please review again :) |
Member
|
Thank you <3 |
This was referenced Nov 27, 2023
This was referenced Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #631
Had to create PR with branch from ipfs/js-ipfs instead of my fork, since running Sauce Labs would fail otherwise. See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions