This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fix: disallow publishing pubsub messages to zero peers#4286
Merged
Conversation
Use the default gossipsub behaviour of not allowing publishing message to zero peers. If a user publishes a message they may be suprised to find it's not been recieved by anyone, so instead an error should be thrown when there are no peers that will receive a message.
This was referenced Feb 2, 2024
This was referenced Feb 2, 2024
This was referenced Feb 2, 2024
This was referenced Feb 2, 2024
This was referenced Feb 3, 2024
This was referenced Feb 3, 2024
This was referenced Feb 3, 2024
This was referenced Feb 3, 2024
This was referenced Apr 1, 2024
This was referenced May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the default gossipsub behaviour of not allowing publishing message to zero peers.
If a user publishes a message they may be suprised to find it's not been recieved by anyone, so instead an error should be thrown when there are no peers that will receive a message.