Skip to content

Ignore expression code fix#1253

Merged
TheAngryByrd merged 9 commits into
ionide:nightlyfrom
nojaf:IgnoreExpression
Apr 12, 2024
Merged

Ignore expression code fix#1253
TheAngryByrd merged 9 commits into
ionide:nightlyfrom
nojaf:IgnoreExpression

Conversation

@nojaf

@nojaf nojaf commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

IgnoreExpression

@nojaf

nojaf commented Mar 28, 2024

Copy link
Copy Markdown
Contributor Author

Ready for review.

Comment thread src/FsAutoComplete/CodeFixes/IgnoreExpression.fs Outdated
Comment thread src/FsAutoComplete/CodeFixes/IgnoreExpression.fs Outdated
@nojaf

nojaf commented Mar 28, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the input @brianrourkeboll!

Comment thread src/FsAutoComplete/CodeFixes/IgnoreExpression.fs
Comment thread src/FsAutoComplete/CodeFixes/IgnoreExpression.fs
@nojaf nojaf mentioned this pull request Apr 8, 2024
@nojaf

nojaf commented Apr 8, 2024

Copy link
Copy Markdown
Contributor Author

Ready for review.

Comment thread test/FsAutoComplete.Tests.Lsp/CodeFixTests/IgnoreExpressionTests.fs

@TheAngryByrd TheAngryByrd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@nojaf

nojaf commented Apr 12, 2024

Copy link
Copy Markdown
Contributor Author

@TheAngryByrd how about merging this one in?

@TheAngryByrd TheAngryByrd merged commit b5fa4aa into ionide:nightly Apr 12, 2024
@TheAngryByrd

Copy link
Copy Markdown
Member

Hmm for some reason I thought I did. Thanks for the reminder!

@nojaf

nojaf commented Apr 12, 2024

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants