Add keep-alive functionality#18561
Closed
michaeltintiuc wants to merge 6 commits intoionic-team:masterfrom
Closed
Conversation
|
This would be very good! |
|
@mhartington Lets merge this, shall we? |
|
Is this implementation already working? |
Contributor
Author
|
@guilhermeagirardi would appreciate you testing this feature here https://github.com/ModusCreateOrg/ionic-vue if building from source is a problem. Consider this PR an RFC, any feedback is highly valuable |
Contributor
|
Thanks for the PR! I am going to close this as this is for the old Ionic Vue code base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
There is no way to cache components using
ion-vue-routerdue limitations imposed by Vue API which state thatkeep-aliveshould be a direct child oftransitionwhen used together.Issue Number: N/A
What is the new behavior?
Allows usage of
keep-aliveas a property ofion-vue-routerBasic usage:
<ion-vue-router keep-alive />Equates to:
Passing props:
<ion-vue-router :keep-alive="{ include: 'SomeComponent' }" />Equates to:
Same as the original API you can pass
string,string[]orRegExptoincludeandexcludeproperties.RegExp:
<ion-vue-router :keep-alive="{ include: /Some/ }" />Equates to:
Does this introduce a breaking change?