Skip to content

[PB-5957]: fix/remove max space occupied pre-check for shared uploads#1931

Open
xabg2 wants to merge 3 commits intomasterfrom
fix/remove-is-upload-allowed-for-shared-uploads
Open

[PB-5957]: fix/remove max space occupied pre-check for shared uploads#1931
xabg2 wants to merge 3 commits intomasterfrom
fix/remove-is-upload-allowed-for-shared-uploads

Conversation

@xabg2
Copy link
Copy Markdown
Contributor

@xabg2 xabg2 commented Apr 14, 2026

Description

Removing the pre-check of max space occupied when the user is uploading items on a shared folders. This was causing problems when a user with EDITOR role is uploading items, because we were checking if the user has free space in his account, not the owner account.

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Additional Notes

@xabg2 xabg2 self-assigned this Apr 14, 2026
@xabg2 xabg2 added the bug Something isn't working label Apr 14, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 14, 2026

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 254f17c
Status: ✅  Deploy successful!
Preview URL: https://f2a6ab02.drive-web.pages.dev
Branch Preview URL: https://fix-remove-is-upload-allowed.drive-web.pages.dev

View logs

Copy link
Copy Markdown
Collaborator

@CandelR CandelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting the modal that warns the user that the owner hasn't enough space :)

@xabg2
Copy link
Copy Markdown
Contributor Author

xabg2 commented Apr 15, 2026

The reached plan dialog has been modified for shared folders. See the attached image to see how it looks now for shared folders.
Captura de pantalla 2026-04-15 a las 10 30 35

@xabg2 xabg2 requested a review from CandelR April 15, 2026 09:17
CandelR
CandelR previously approved these changes Apr 15, 2026
@xabg2 xabg2 requested a review from a team as a code owner April 15, 2026 14:38
@xabg2 xabg2 requested a review from CandelR April 15, 2026 14:40
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
30.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants