Skip to content

[_] feature/Updated dependencies and updated related tests#1929

Open
CandelR wants to merge 11 commits intomasterfrom
feature/update-sdk-and-fix-security-issues
Open

[_] feature/Updated dependencies and updated related tests#1929
CandelR wants to merge 11 commits intomasterfrom
feature/update-sdk-and-fix-security-issues

Conversation

@CandelR
Copy link
Copy Markdown
Collaborator

@CandelR CandelR commented Apr 10, 2026

Description

  • Update dependencies and fix related security vulnerabilities
  • Update sdk
  • Upload was broken locally with a window is undefined error. uploadWorkerUtils imported notifyUserWithCooldown directly as a static dependency, causing it to be evaluated inside the worker context where window and other browser APIs (notificationsService, i18next) are not available. Refactored to receive onRateLimited as an injected callback from network.service, which runs in the main thread where those APIs work correctly.

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

  • Login with wrong credentials shows backend error message
  • Password protected shared link - wrong password shows inline error, correct password loads content
  • Invalid/expired shared link - shows "link expired" screen
  • Rate limit display notification
  • Upload items working as expected

Additional Notes

@CandelR CandelR self-assigned this Apr 10, 2026
@CandelR CandelR requested review from a team and larryrider as code owners April 10, 2026 11:53
@CandelR CandelR added bug Something isn't working enhancement New feature or request dependencies Pull requests that update a dependency file labels Apr 10, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 10, 2026

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7904b60
Status: ✅  Deploy successful!
Preview URL: https://d625275f.drive-web.pages.dev
Branch Preview URL: https://feature-update-sdk-and-fix-s.drive-web.pages.dev

View logs

@CandelR CandelR marked this pull request as draft April 10, 2026 13:12
@sonarqubecloud
Copy link
Copy Markdown

@CandelR CandelR marked this pull request as ready for review April 15, 2026 08:27
@CandelR CandelR requested a review from xabg2 April 15, 2026 08:27
@CandelR CandelR changed the title Updated dependencies and updated related tests [_] feature/Updated dependencies and updated related tests Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant