feat: implement open virtual drive folder functionality and error handling#312
Open
egalvis27 wants to merge 1 commit intofeat/go-fuse-daemonfrom
Open
feat: implement open virtual drive folder functionality and error handling#312egalvis27 wants to merge 1 commit intofeat/go-fuse-daemonfrom
egalvis27 wants to merge 1 commit intofeat/go-fuse-daemonfrom
Conversation
egalvis27
commented
Apr 15, 2026
| MaxReadAhead: 128 * 1024, | ||
| DisableXAttrs: false, | ||
| Debug: false, | ||
| DirectMount: true, |
Author
There was a problem hiding this comment.
Added a new parameter that, according to the documentation, cleans up existing mounts before remounting. This prevents orphaned mounts from causing remount failures.
https://github.com/hanwen/go-fuse/blob/v2.9.0/fuse/api.go#L312
|
egalvis27
commented
Apr 15, 2026
Comment on lines
39
to
57
| func (fs *InternxtFilesystem) GetAttr(name string, context *fuse.Context) (*fuse.Attr, fuse.Status) { | ||
| fs.logger.Warn("not implemented", "op", "GetAttr", "path", name) | ||
| return nil, fuse.ENOSYS | ||
| if isRootPath(name) { | ||
| return &fuse.Attr{ | ||
| Mode: uint32(syscall.S_IFDIR | 0o755), | ||
| Nlink: 2, | ||
| Owner: fuse.Owner{Uid: context.Owner.Uid, Gid: context.Owner.Gid}, | ||
| }, fuse.OK | ||
| } | ||
|
|
||
| return nil, fuse.ENOENT | ||
| } | ||
|
|
||
| func (fs *InternxtFilesystem) OpenDir(name string, context *fuse.Context) ([]fuse.DirEntry, fuse.Status) { | ||
| fs.logger.Warn("not implemented", "op", "OpenDir", "path", name) | ||
| return nil, fuse.ENOSYS | ||
| if isRootPath(name) { | ||
| return []fuse.DirEntry{}, fuse.OK | ||
| } | ||
|
|
||
| return nil, fuse.ENOENT | ||
| } |
Author
There was a problem hiding this comment.
These callbacks currently include only the bare minimum required to access the folder. Once the drive content loading logic is implemented, these elements will likely be relocated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
When switching to the new daemon, the option to open the virtual drive folder from the widget had stopped working; this functionality has now been restored.