Conversation
…ile services and update repository initialization
AlexisMora
reviewed
Apr 13, 2026
|
|
||
| const dataSource = await TypeOrmStorageFilesDataSourceFactory.create(); | ||
| if (!AppDataSource.isInitialized) { | ||
| throw new Error('AppDataSource must be initialized before registerStorageFilesServices'); |
There was a problem hiding this comment.
What happens when we throw this exception? is it handled or it just bubbles up and stops the execution entirely? if its the later, shouldnt we handle it properly?
|
AlexisMora
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
An issue was encountered during login where a critical database table required for Fuse functions was not created. Some tables were being initialized when the application started, and others when the user logged in, which caused a race condition where Fuse attempted to run queries before the table existed.
The initialization of the tables has been centralized so that all tables exist before logging in, thereby avoiding this problem, and the entire database initialization process has been consolidated into a single location.