Improve resource handling to follow MCP specification #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change URI protocol from file:// to resource://
- Add MIME type detection using Python's mimetypes library
- Update resource metadata structure:
- uri: Unique identifier with protocol (resource://skillz/{skill}/{path})
- name: Path without protocol ({skill}/{path})
- mime_type: Detected MIME type or None
- Remove description and relative_path fields
- Ensure UTF-8 text and binary (base64) content handled correctly
- Add comprehensive tests for resource metadata compliance
Follows guidance from:
https://modelcontextprotocol.info/docs/concepts/resources/
SKILL.md should only be returned from the tool invocation, not as a resource. All other files in the skill directory and subdirectories are available as resources. - Updated _collect_resources to exclude SKILL.md - Updated tests to verify SKILL.md is not in resources - All other files remain accessible as resources
- Remove FastMCP-specific reference to ctx.read_resource() - Replace with generic description of retrieving resources from MCP server - Remove special mention of scripts (clients know what to do with them) - Clarify that clients should retrieve resources when instructions reference additional files and it's appropriate for the task - Add description of resource metadata fields (uri, name, mime_type)
- Break long line in docstring (line 269) - Remove unused variable and import in test_resources.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates resource metadata and handling to fully comply with the MCP specification for resources.
Changes
Resource Metadata (MCP Compliance)
file://toresource://resource://skillz/{skill-slug}/{path}uri: Unique identifier with protocolname: Path without protocol prefixmime_type: Auto-detected MIME type (or None)descriptionandrelative_pathfieldsmimetypeslibraryResource Collection
instructionsfield, not as a separate resourceClient-Agnostic Documentation
ctx.read_resource())Testing
Commits